Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: Source/modules/presentation/PresentationSessionClientCallbacks.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: smaller review updates Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/presentation/PresentationSessionClientCallbacks.h
diff --git a/Source/modules/presentation/PresentationSessionClientCallbacks.h b/Source/modules/presentation/PresentationSessionClientCallbacks.h
index 6ac5230807e9cf5b4cd5f1e4e85a8fa89fcea091..193d92643038ad050f3a15fe8b9dbcd4551637cf 100644
--- a/Source/modules/presentation/PresentationSessionClientCallbacks.h
+++ b/Source/modules/presentation/PresentationSessionClientCallbacks.h
@@ -8,8 +8,6 @@
#include "platform/heap/Handle.h"
#include "public/platform/modules/presentation/WebPresentationClient.h"
#include "wtf/Noncopyable.h"
-#include "wtf/PassRefPtr.h"
-#include "wtf/RefPtr.h"
namespace blink {
@@ -27,7 +25,7 @@ class ScriptPromiseResolver;
class PresentationSessionClientCallbacks final : public WebPresentationSessionClientCallbacks {
WTF_MAKE_NONCOPYABLE(PresentationSessionClientCallbacks);
public:
- PresentationSessionClientCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver>, Presentation*);
+ PresentationSessionClientCallbacks(ScriptPromiseResolver*, Presentation*);
~PresentationSessionClientCallbacks() override;
// WebPresentationSessionClientCallbacks implementation.
@@ -35,7 +33,7 @@ public:
void onError(WebPresentationError*) override;
private:
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
Persistent<Presentation> m_presentation;
};

Powered by Google App Engine
This is Rietveld 408576698