Source/modules/presentation/Presentation.cpp - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/presentation/Presentation.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: smaller review updates Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/mediastream/MediaDevices.cpp ('K') | « Source/modules/permissions/Permissions.cpp ('k') | Source/modules/presentation/PresentationAvailabilityCallback.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/presentation/Presentation.cpp

diff --git a/Source/modules/presentation/Presentation.cpp b/Source/modules/presentation/Presentation.cpp

index 27469b607ca315d278d82dbcdc78f6a4eaf336ba..83283ef2ec001cee9f8048de8a13f9a32a3d72c6 100644

--- a/Source/modules/presentation/Presentation.cpp

+++ b/Source/modules/presentation/Presentation.cpp

@@ -86,7 +86,7 @@ PresentationSession* Presentation::session() const

ScriptPromise Presentation::startSession(ScriptState* state, const String& presentationUrl)

{

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(state);

+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(state);

ScriptPromise promise = resolver->promise();

WebPresentationClient* client = presentationClient(executionContext());

@@ -101,7 +101,7 @@ ScriptPromise Presentation::startSession(ScriptState* state, const String& prese

ScriptPromise Presentation::joinSession(ScriptState* state, const String& presentationUrl, const String& presentationId)

{

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(state);

+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(state);

ScriptPromise promise = resolver->promise();

WebPresentationClient* client = presentationClient(executionContext());

@@ -116,7 +116,7 @@ ScriptPromise Presentation::joinSession(ScriptState* state, const String& presen

ScriptPromise Presentation::getAvailability(ScriptState* state, const String& presentationUrl)

{

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(state);

+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(state);

ScriptPromise promise = resolver->promise();

WebPresentationClient* client = presentationClient(executionContext());