Source/modules/permissions/PermissionQueryCallback.cpp - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/permissions/PermissionQueryCallback.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: smaller review updates Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/mediastream/MediaDevices.cpp ('K') | « Source/modules/permissions/PermissionQueryCallback.h ('k') | Source/modules/permissions/Permissions.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/permissions/PermissionQueryCallback.cpp

diff --git a/Source/modules/permissions/PermissionQueryCallback.cpp b/Source/modules/permissions/PermissionQueryCallback.cpp

index 95f849b52f03a18eb622736dc37bac9b0155e0a6..c421b2e47831e9c18ef39dc275e083cb8d5fbc28 100644

--- a/Source/modules/permissions/PermissionQueryCallback.cpp

+++ b/Source/modules/permissions/PermissionQueryCallback.cpp

@@ -10,7 +10,7 @@

namespace blink {

-PermissionQueryCallback::PermissionQueryCallback(PassRefPtr<ScriptPromiseResolver> resolver, WebPermissionType permissionType)

+PermissionQueryCallback::PermissionQueryCallback(ScriptPromiseResolver* resolver, WebPermissionType permissionType)

: m_resolver(resolver)

, m_permissionType(permissionType)

{