Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: smaller review updates Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/crypto/CryptoResultImpl.cpp ('K') | « Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp ('k') | Source/modules/fetch/Body.h » ('j') | Source/modules/mediastream/MediaDevices.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp

diff --git a/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp b/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp

index e90e0e1b80506adc742ea818d1bbdf997615580f..5f4f39032914aeb977a01464983e8908335118e6 100644

--- a/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp

+++ b/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp

@@ -95,8 +95,14 @@ public:

ScriptPromise promise() { return m_resolver->promise(); }

+ DEFINE_INLINE_VIRTUAL_TRACE()

+ {

+ visitor->trace(m_resolver);

+ EncryptedMediaRequest::trace(visitor);

+ }

private:

- RefPtr<ScriptPromiseResolver> m_resolver;

+ Member<ScriptPromiseResolver> m_resolver;

const String m_keySystem;

WebVector<WebMediaKeySystemConfiguration> m_supportedConfigurations;

};