Source/modules/app_banner/BeforeInstallPromptEvent.cpp - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/app_banner/BeforeInstallPromptEvent.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: smaller review updates Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptPromiseResolverTest.cpp ('K') | « Source/core/testing/Internals.cpp ('k') | Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp » ('j') | Source/modules/cachestorage/Cache.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/app_banner/BeforeInstallPromptEvent.cpp

diff --git a/Source/modules/app_banner/BeforeInstallPromptEvent.cpp b/Source/modules/app_banner/BeforeInstallPromptEvent.cpp

index 74cdab48b06f844afaf94119b8a34e03fb48a2cc..229c233190ee61263323b33deb0670f52bec4d9b 100644

--- a/Source/modules/app_banner/BeforeInstallPromptEvent.cpp

+++ b/Source/modules/app_banner/BeforeInstallPromptEvent.cpp

@@ -51,7 +51,7 @@ ScriptPromise BeforeInstallPromptEvent::userChoice(ScriptState* scriptState)

{

if (m_userChoice.isEmpty() && m_client) {

ASSERT(m_requestId != -1);

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

m_userChoice = resolver->promise();

m_client->registerBannerCallbacks(m_requestId, new CallbackPromiseAdapter<AppBannerPromptResult, void>(resolver));

}