Source/core/css/FontFaceSet.h - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/FontFaceSet.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: smaller review updates Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptPromiseResolverTest.cpp ('K') | « Source/bindings/core/v8/ScriptPromiseResolverTest.cpp ('k') | Source/core/css/FontFaceSet.cpp » ('j') | Source/modules/cachestorage/Cache.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/FontFaceSet.h

diff --git a/Source/core/css/FontFaceSet.h b/Source/core/css/FontFaceSet.h

index b3c9102608511f5cb412619315207de29d69187a..cf6c5cf39f4e7715317350930c6255ef245a8200 100644

--- a/Source/core/css/FontFaceSet.h

+++ b/Source/core/css/FontFaceSet.h

@@ -148,7 +148,7 @@ private:

WillBeHeapHashSet<RefPtrWillBeMember<FontFace>> m_loadingFonts;

bool m_shouldFireLoadingEvent;

- WillBeHeapVector<OwnPtrWillBeMember<FontsReadyPromiseResolver>> m_readyResolvers;

+ PersistentHeapVectorWillBeHeapVector<Member<FontsReadyPromiseResolver>> m_readyResolvers;

FontFaceArray m_loadedFonts;

FontFaceArray m_failedFonts;

WillBeHeapListHashSet<RefPtrWillBeMember<FontFace>> m_nonCSSConnectedFaces;