Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: Source/bindings/core/v8/CallbackPromiseAdapter.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: smaller review updates Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/CallbackPromiseAdapter.h
diff --git a/Source/bindings/core/v8/CallbackPromiseAdapter.h b/Source/bindings/core/v8/CallbackPromiseAdapter.h
index dfb53df956529a2c8cc037083ce7cbc977b0280a..db1ec18506f12b1d21cb464a0ea67c46b2c40e3e 100644
--- a/Source/bindings/core/v8/CallbackPromiseAdapter.h
+++ b/Source/bindings/core/v8/CallbackPromiseAdapter.h
@@ -76,7 +76,7 @@ template<typename S, typename T>
class CallbackPromiseAdapter final : public WebCallbacks<typename S::WebType, typename T::WebType> {
WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
public:
- explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
+ explicit CallbackPromiseAdapter(ScriptPromiseResolver* resolver)
: m_resolver(resolver)
{
ASSERT(m_resolver);
@@ -106,14 +106,14 @@ public:
}
private:
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
};
template<typename T>
class CallbackPromiseAdapter<void, T> final : public WebCallbacks<void, typename T::WebType> {
WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
public:
- explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
+ explicit CallbackPromiseAdapter(ScriptPromiseResolver* resolver)
: m_resolver(resolver)
{
ASSERT(m_resolver);
@@ -137,14 +137,14 @@ public:
}
private:
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
};
template<typename S>
class CallbackPromiseAdapter<S, void> final : public WebCallbacks<typename S::WebType, void> {
WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
public:
- explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
+ explicit CallbackPromiseAdapter(ScriptPromiseResolver* resolver)
: m_resolver(resolver)
{
ASSERT(m_resolver);
@@ -168,14 +168,14 @@ public:
}
private:
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
};
template<typename T>
class CallbackPromiseAdapter<bool, T> final : public WebCallbacks<bool, typename T::WebType> {
WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
public:
- explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
+ explicit CallbackPromiseAdapter(ScriptPromiseResolver* resolver)
: m_resolver(resolver)
{
ASSERT(m_resolver);
@@ -201,14 +201,14 @@ public:
}
private:
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
};
template<>
class CallbackPromiseAdapter<void, void> final : public WebCallbacks<void, void> {
WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
public:
- explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
+ explicit CallbackPromiseAdapter(ScriptPromiseResolver* resolver)
: m_resolver(resolver)
{
ASSERT(m_resolver);
@@ -230,14 +230,14 @@ public:
}
private:
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
};
template<>
class CallbackPromiseAdapter<bool, void> final : public WebCallbacks<bool, void> {
WTF_MAKE_NONCOPYABLE(CallbackPromiseAdapter);
public:
- explicit CallbackPromiseAdapter(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
+ explicit CallbackPromiseAdapter(ScriptPromiseResolver* resolver)
: m_resolver(resolver)
{
ASSERT(m_resolver);
@@ -261,7 +261,7 @@ public:
}
private:
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
};
} // namespace blink
« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptPromiseResolver.h » ('j') | Source/bindings/core/v8/ScriptPromiseResolver.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698