Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1479)

Unified Diff: Source/modules/push_messaging/PushSubscriptionCallbacks.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: tidy unit tests Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/push_messaging/PushSubscriptionCallbacks.h
diff --git a/Source/modules/push_messaging/PushSubscriptionCallbacks.h b/Source/modules/push_messaging/PushSubscriptionCallbacks.h
index 75cd6d3ddf727f9ddefb006b9e6f5c5646130daf..287a4547c52b63135653d45043340252fd8bfc4e 100644
--- a/Source/modules/push_messaging/PushSubscriptionCallbacks.h
+++ b/Source/modules/push_messaging/PushSubscriptionCallbacks.h
@@ -8,8 +8,6 @@
#include "platform/heap/Handle.h"
#include "public/platform/WebCallbacks.h"
#include "wtf/Noncopyable.h"
-#include "wtf/PassRefPtr.h"
-#include "wtf/RefPtr.h"
namespace blink {
@@ -25,14 +23,14 @@ struct WebPushSubscription;
class PushSubscriptionCallbacks final : public WebCallbacks<WebPushSubscription, WebPushError> {
WTF_MAKE_NONCOPYABLE(PushSubscriptionCallbacks);
public:
- PushSubscriptionCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver>, ServiceWorkerRegistration*);
+ PushSubscriptionCallbacks(ScriptPromiseResolver*, ServiceWorkerRegistration*);
~PushSubscriptionCallbacks() override;
void onSuccess(WebPushSubscription*) override;
void onError(WebPushError*) override;
private:
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
Persistent<ServiceWorkerRegistration> m_serviceWorkerRegistration;
};

Powered by Google App Engine
This is Rietveld 408576698