Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1495)

Unified Diff: Source/modules/permissions/PermissionQueryCallback.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: tidy unit tests Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/permissions/PermissionQueryCallback.h
diff --git a/Source/modules/permissions/PermissionQueryCallback.h b/Source/modules/permissions/PermissionQueryCallback.h
index c5631582b2830013d8a202ab6087091da244a758..88965a50e884b89b8059003ecf2984fc6e551f15 100644
--- a/Source/modules/permissions/PermissionQueryCallback.h
+++ b/Source/modules/permissions/PermissionQueryCallback.h
@@ -10,8 +10,6 @@
#include "public/platform/modules/permissions/WebPermissionStatus.h"
#include "public/platform/modules/permissions/WebPermissionType.h"
#include "wtf/Noncopyable.h"
-#include "wtf/PassRefPtr.h"
-#include "wtf/RefPtr.h"
namespace blink {
@@ -24,14 +22,14 @@ class ScriptPromiseResolver;
class PermissionQueryCallback final
: public WebCallbacks<WebPermissionStatus, void> {
public:
- explicit PermissionQueryCallback(PassRefPtr<ScriptPromiseResolver>, WebPermissionType);
+ explicit PermissionQueryCallback(ScriptPromiseResolver*, WebPermissionType);
~PermissionQueryCallback() override;
void onSuccess(WebPermissionStatus*) override;
void onError() override;
private:
- RefPtr<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
WebPermissionType m_permissionType;
WTF_MAKE_NONCOPYABLE(PermissionQueryCallback);

Powered by Google App Engine
This is Rietveld 408576698