Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1599)

Unified Diff: Source/core/streams/ReadableStreamImpl.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: tidy unit tests Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/streams/ReadableStreamImpl.h
diff --git a/Source/core/streams/ReadableStreamImpl.h b/Source/core/streams/ReadableStreamImpl.h
index 719fe8e040a940fe2c8cb9456434f1bfc9b3cee0..fc3d3f5e8d1ba69a473a1c9a330b22e1feec75ca 100644
--- a/Source/core/streams/ReadableStreamImpl.h
+++ b/Source/core/streams/ReadableStreamImpl.h
@@ -118,18 +118,12 @@ public:
DEFINE_INLINE_VIRTUAL_TRACE()
{
visitor->trace(m_strategy);
-#if ENABLE(OILPAN)
visitor->trace(m_pendingReads);
-#endif
ReadableStream::trace(visitor);
}
private:
-#if ENABLE(OILPAN)
using PendingReads = HeapDeque<Member<ScriptPromiseResolver>>;
-#else
- using PendingReads = Deque<RefPtr<ScriptPromiseResolver>>;
-#endif
// ReadableStream methods
bool isQueueEmpty() const override { return m_queue.isEmpty(); }
@@ -180,7 +174,7 @@ bool ReadableStreamImpl<ChunkTypeTraits>::enqueue(typename ChunkTypeTraits::Pass
return enqueuePostAction();
}
- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = m_pendingReads.takeFirst();
+ ScriptPromiseResolver* resolver = m_pendingReads.takeFirst();
ScriptState* scriptState = resolver->scriptState();
haraken 2015/07/17 01:40:35 Not related to this CL, we should have: if (!sc
sof 2015/07/17 09:43:26 Done, here & in resolveAllPendingReadsAsDone() yh
yhirano 2015/07/17 13:53:41 haraken@: Is it guaranteed that the document is st
haraken 2015/07/18 07:10:27 It is guaranteed for a document that is associated
ScriptState::Scope scope(scriptState);
resolver->resolve(v8IteratorResult(scriptState, chunk));

Powered by Google App Engine
This is Rietveld 408576698