Source/web/StorageQuotaClientImpl.cpp - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/StorageQuotaClientImpl.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: retain resolver when delay'edly resolving Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptPromiseResolverTest.cpp ('K') | « Source/platform/exported/WebCryptoResult.cpp ('k') | Source/web/WebMIDIPermissionRequest.cpp » ('j') | public/web/WebMIDIPermissionRequest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/StorageQuotaClientImpl.cpp

diff --git a/Source/web/StorageQuotaClientImpl.cpp b/Source/web/StorageQuotaClientImpl.cpp

index 1d1a4a21ca70588c17bd78fc270c5aa14063ac05..d782cdb94b9b55d1ff1d8df6cd6c1f810828dc02 100644

--- a/Source/web/StorageQuotaClientImpl.cpp

+++ b/Source/web/StorageQuotaClientImpl.cpp

@@ -75,7 +75,7 @@ void StorageQuotaClientImpl::requestQuota(ExecutionContext* executionContext, We

ScriptPromise StorageQuotaClientImpl::requestPersistentQuota(ScriptState* scriptState, unsigned long long newQuotaInBytes)

{

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

if (scriptState->executionContext()->isDocument()) {