Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: Source/modules/push_messaging/PushSubscriptionCallbacks.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix webusb ScriptPromiseResolver usage Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/push_messaging/PushSubscriptionCallbacks.h" 6 #include "modules/push_messaging/PushSubscriptionCallbacks.h"
7 7
8 #include "bindings/core/v8/ScriptPromiseResolver.h" 8 #include "bindings/core/v8/ScriptPromiseResolver.h"
9 #include "modules/push_messaging/PushError.h" 9 #include "modules/push_messaging/PushError.h"
10 #include "modules/push_messaging/PushSubscription.h" 10 #include "modules/push_messaging/PushSubscription.h"
11 #include "modules/serviceworkers/ServiceWorkerRegistration.h" 11 #include "modules/serviceworkers/ServiceWorkerRegistration.h"
12 12
13 namespace blink { 13 namespace blink {
14 14
15 PushSubscriptionCallbacks::PushSubscriptionCallbacks(PassRefPtrWillBeRawPtr<Scri ptPromiseResolver> resolver, ServiceWorkerRegistration* serviceWorkerRegistratio n) 15 PushSubscriptionCallbacks::PushSubscriptionCallbacks(ScriptPromiseResolver* reso lver, ServiceWorkerRegistration* serviceWorkerRegistration)
16 : m_resolver(resolver) 16 : m_resolver(resolver)
17 , m_serviceWorkerRegistration(serviceWorkerRegistration) 17 , m_serviceWorkerRegistration(serviceWorkerRegistration)
18 { 18 {
19 ASSERT(m_resolver); 19 ASSERT(m_resolver);
20 ASSERT(m_serviceWorkerRegistration); 20 ASSERT(m_serviceWorkerRegistration);
21 } 21 }
22 22
23 PushSubscriptionCallbacks::~PushSubscriptionCallbacks() 23 PushSubscriptionCallbacks::~PushSubscriptionCallbacks()
24 { 24 {
25 } 25 }
(...skipping 12 matching lines...) Expand all
38 38
39 void PushSubscriptionCallbacks::onError(WebPushError* error) 39 void PushSubscriptionCallbacks::onError(WebPushError* error)
40 { 40 {
41 OwnPtr<WebPushError> ownError = adoptPtr(error); 41 OwnPtr<WebPushError> ownError = adoptPtr(error);
42 if (!m_resolver->executionContext() || m_resolver->executionContext()->activ eDOMObjectsAreStopped()) 42 if (!m_resolver->executionContext() || m_resolver->executionContext()->activ eDOMObjectsAreStopped())
43 return; 43 return;
44 m_resolver->reject(PushError::take(m_resolver.get(), ownError.release())); 44 m_resolver->reject(PushError::take(m_resolver.get(), ownError.release()));
45 } 45 }
46 46
47 } // namespace blink 47 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/push_messaging/PushSubscriptionCallbacks.h ('k') | Source/modules/quota/StorageQuota.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698