Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Side by Side Diff: Source/modules/permissions/PermissionCallback.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix webusb ScriptPromiseResolver usage Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/permissions/PermissionCallback.h" 6 #include "modules/permissions/PermissionCallback.h"
7 7
8 #include "bindings/core/v8/ScriptPromiseResolver.h" 8 #include "bindings/core/v8/ScriptPromiseResolver.h"
9 #include "modules/permissions/PermissionStatus.h" 9 #include "modules/permissions/PermissionStatus.h"
10 10
11 namespace blink { 11 namespace blink {
12 12
13 PermissionCallback::PermissionCallback(PassRefPtr<ScriptPromiseResolver> resolve r, WebPermissionType permissionType) 13 PermissionCallback::PermissionCallback(ScriptPromiseResolver* resolver, WebPermi ssionType permissionType)
14 : m_resolver(resolver) 14 : m_resolver(resolver)
15 , m_permissionType(permissionType) 15 , m_permissionType(permissionType)
16 { 16 {
17 ASSERT(m_resolver); 17 ASSERT(m_resolver);
18 } 18 }
19 19
20 PermissionCallback::~PermissionCallback() 20 PermissionCallback::~PermissionCallback()
21 { 21 {
22 } 22 }
23 23
24 void PermissionCallback::onSuccess(WebPermissionStatus* permissionStatus) 24 void PermissionCallback::onSuccess(WebPermissionStatus* permissionStatus)
25 { 25 {
26 if (!m_resolver->executionContext() || m_resolver->executionContext()->activ eDOMObjectsAreStopped()) { 26 if (!m_resolver->executionContext() || m_resolver->executionContext()->activ eDOMObjectsAreStopped()) {
27 PermissionStatus::dispose(permissionStatus); 27 PermissionStatus::dispose(permissionStatus);
28 return; 28 return;
29 } 29 }
30 m_resolver->resolve(PermissionStatus::take(m_resolver.get(), permissionStatu s, m_permissionType)); 30 m_resolver->resolve(PermissionStatus::take(m_resolver.get(), permissionStatu s, m_permissionType));
31 } 31 }
32 32
33 void PermissionCallback::onError() 33 void PermissionCallback::onError()
34 { 34 {
35 if (!m_resolver->executionContext() || m_resolver->executionContext()->activ eDOMObjectsAreStopped()) { 35 if (!m_resolver->executionContext() || m_resolver->executionContext()->activ eDOMObjectsAreStopped()) {
36 return; 36 return;
37 } 37 }
38 m_resolver->reject(); 38 m_resolver->reject();
39 } 39 }
40 40
41 } // namespace blink 41 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/permissions/PermissionCallback.h ('k') | Source/modules/permissions/Permissions.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698