Source/modules/mediastream/MediaDevicesRequest.h - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/mediastream/MediaDevicesRequest.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix webusb ScriptPromiseResolver usage Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2014 Google Inc. All rights reserved.	2 * Copyright (C) 2014 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55	55

56 // ActiveDOMObject	56 // ActiveDOMObject

57 void stop() override;	57 void stop() override;

58	58

59 DECLARE_VIRTUAL_TRACE();	59 DECLARE_VIRTUAL_TRACE();

60	60

61 private:	61 private:

62 MediaDevicesRequest(ScriptState, UserMediaController);	62 MediaDevicesRequest(ScriptState, UserMediaController);

63	63

64 RawPtrWillBeMember<UserMediaController> m_controller;	64 RawPtrWillBeMember<UserMediaController> m_controller;

65 RefPtrWillBeMember<ScriptPromiseResolver> m_resolver;	65 Member<ScriptPromiseResolver> m_resolver;

66 };	66 };

67	67

68 } // namespace blink	68 } // namespace blink

69	69

70 #endif // MediaDevicesRequest_h	70 #endif // MediaDevicesRequest_h

OLD	NEW

« no previous file with comments | « Source/modules/mediastream/MediaDevices.cpp ('k') | Source/modules/navigatorconnect/AcceptConnectionObserver.h » ('j') | no next file with comments »