Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: Source/modules/bluetooth/Bluetooth.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix webusb ScriptPromiseResolver usage Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/bluetooth/Bluetooth.h" 6 #include "modules/bluetooth/Bluetooth.h"
7 7
8 #include "bindings/core/v8/CallbackPromiseAdapter.h" 8 #include "bindings/core/v8/CallbackPromiseAdapter.h"
9 #include "bindings/core/v8/ScriptPromise.h" 9 #include "bindings/core/v8/ScriptPromise.h"
10 #include "bindings/core/v8/ScriptPromiseResolver.h" 10 #include "bindings/core/v8/ScriptPromiseResolver.h"
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 if (!webbluetooth) 68 if (!webbluetooth)
69 return ScriptPromise::rejectWithDOMException(scriptState, DOMException:: create(NotSupportedError)); 69 return ScriptPromise::rejectWithDOMException(scriptState, DOMException:: create(NotSupportedError));
70 70
71 // 3. In order to convert the arguments from service names and aliases to ju st UUIDs, do the following substeps: 71 // 3. In order to convert the arguments from service names and aliases to ju st UUIDs, do the following substeps:
72 WebRequestDeviceOptions webOptions; 72 WebRequestDeviceOptions webOptions;
73 convertRequestDeviceOptions(options, webOptions, exceptionState); 73 convertRequestDeviceOptions(options, webOptions, exceptionState);
74 if (exceptionState.hadException()) 74 if (exceptionState.hadException())
75 return exceptionState.reject(scriptState); 75 return exceptionState.reject(scriptState);
76 76
77 // Subsequent steps are handled in the browser process. 77 // Subsequent steps are handled in the browser process.
78 RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver:: create(scriptState); 78 ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState) ;
79 ScriptPromise promise = resolver->promise(); 79 ScriptPromise promise = resolver->promise();
80 webbluetooth->requestDevice(webOptions, new CallbackPromiseAdapter<Bluetooth Device, BluetoothError>(resolver)); 80 webbluetooth->requestDevice(webOptions, new CallbackPromiseAdapter<Bluetooth Device, BluetoothError>(resolver));
81 return promise; 81 return promise;
82 82
83 } 83 }
84 84
85 } // namespace blink 85 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/background_sync/SyncRegistration.cpp ('k') | Source/modules/bluetooth/BluetoothDevice.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698