Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: Source/modules/background_sync/SyncRegistration.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix webusb ScriptPromiseResolver usage Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/background_sync/SyncManager.cpp ('k') | Source/modules/bluetooth/Bluetooth.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/background_sync/SyncRegistration.h" 6 #include "modules/background_sync/SyncRegistration.h"
7 7
8 #include "bindings/core/v8/CallbackPromiseAdapter.h" 8 #include "bindings/core/v8/CallbackPromiseAdapter.h"
9 #include "bindings/core/v8/ScriptPromiseResolver.h" 9 #include "bindings/core/v8/ScriptPromiseResolver.h"
10 #include "core/dom/DOMException.h" 10 #include "core/dom/DOMException.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 SyncRegistration::~SyncRegistration() 49 SyncRegistration::~SyncRegistration()
50 { 50 {
51 } 51 }
52 52
53 ScriptPromise SyncRegistration::unregister(ScriptState* scriptState) 53 ScriptPromise SyncRegistration::unregister(ScriptState* scriptState)
54 { 54 {
55 if (m_id == WebSyncRegistration::UNREGISTERED_SYNC_ID) 55 if (m_id == WebSyncRegistration::UNREGISTERED_SYNC_ID)
56 return ScriptPromise::rejectWithDOMException(scriptState, DOMException:: create(AbortError, "Operation failed - not a valid registration object")); 56 return ScriptPromise::rejectWithDOMException(scriptState, DOMException:: create(AbortError, "Operation failed - not a valid registration object"));
57 57
58 RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver:: create(scriptState); 58 ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState) ;
59 ScriptPromise promise = resolver->promise(); 59 ScriptPromise promise = resolver->promise();
60 60
61 WebSyncProvider* webSyncProvider = Platform::current()->backgroundSyncProvid er(); 61 WebSyncProvider* webSyncProvider = Platform::current()->backgroundSyncProvid er();
62 ASSERT(webSyncProvider); 62 ASSERT(webSyncProvider);
63 63
64 webSyncProvider->unregisterBackgroundSync(WebSyncRegistration::PeriodicityOn eShot, m_id, m_tag, m_serviceWorkerRegistration->webRegistration(), new SyncUnre gistrationCallbacks(resolver, m_serviceWorkerRegistration)); 64 webSyncProvider->unregisterBackgroundSync(WebSyncRegistration::PeriodicityOn eShot, m_id, m_tag, m_serviceWorkerRegistration->webRegistration(), new SyncUnre gistrationCallbacks(resolver, m_serviceWorkerRegistration));
65 65
66 return promise; 66 return promise;
67 } 67 }
68 68
69 DEFINE_TRACE(SyncRegistration) 69 DEFINE_TRACE(SyncRegistration)
70 { 70 {
71 visitor->trace(m_serviceWorkerRegistration); 71 visitor->trace(m_serviceWorkerRegistration);
72 } 72 }
73 73
74 } // namespace blink 74 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/background_sync/SyncManager.cpp ('k') | Source/modules/bluetooth/Bluetooth.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698