Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: Source/modules/bluetooth/BluetoothDevice.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: smaller review updates Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/bluetooth/BluetoothDevice.h" 6 #include "modules/bluetooth/BluetoothDevice.h"
7 7
8 #include "bindings/core/v8/CallbackPromiseAdapter.h" 8 #include "bindings/core/v8/CallbackPromiseAdapter.h"
9 #include "bindings/core/v8/ScriptPromise.h" 9 #include "bindings/core/v8/ScriptPromise.h"
10 #include "bindings/core/v8/ScriptPromiseResolver.h" 10 #include "bindings/core/v8/ScriptPromiseResolver.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 for (size_t i = 0; i < m_webDevice->uuids.size(); ++i) 73 for (size_t i = 0; i < m_webDevice->uuids.size(); ++i)
74 uuids[i] = m_webDevice->uuids[i]; 74 uuids[i] = m_webDevice->uuids[i];
75 return uuids; 75 return uuids;
76 } 76 }
77 77
78 ScriptPromise BluetoothDevice::connectGATT(ScriptState* scriptState) 78 ScriptPromise BluetoothDevice::connectGATT(ScriptState* scriptState)
79 { 79 {
80 WebBluetooth* webbluetooth = Platform::current()->bluetooth(); 80 WebBluetooth* webbluetooth = Platform::current()->bluetooth();
81 if (!webbluetooth) 81 if (!webbluetooth)
82 return ScriptPromise::rejectWithDOMException(scriptState, DOMException:: create(NotSupportedError)); 82 return ScriptPromise::rejectWithDOMException(scriptState, DOMException:: create(NotSupportedError));
83 RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver:: create(scriptState); 83 ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState) ;
84 ScriptPromise promise = resolver->promise(); 84 ScriptPromise promise = resolver->promise();
85 webbluetooth->connectGATT(instanceID(), new CallbackPromiseAdapter<Bluetooth GATTRemoteServer, BluetoothError>(resolver)); 85 webbluetooth->connectGATT(instanceID(), new CallbackPromiseAdapter<Bluetooth GATTRemoteServer, BluetoothError>(resolver));
86 return promise; 86 return promise;
87 } 87 }
88 88
89 } // namespace blink 89 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698