Source/core/imagebitmap/ImageBitmapFactories.h - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/imagebitmap/ImageBitmapFactories.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: smaller review updates Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/bindings/core/v8/ScriptPromiseResolverTest.cpp ('K') | « Source/core/css/FontFaceSet.cpp ('k') | Source/core/imagebitmap/ImageBitmapFactories.cpp » ('j') | Source/modules/cachestorage/Cache.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2013, Google Inc. All rights reserved.	2 * Copyright (c) 2013, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 78 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
89 void rejectPromise();	89 void rejectPromise();

90	90

91 // FileReaderLoaderClient	91 // FileReaderLoaderClient

92 void didStartLoading() override { }	92 void didStartLoading() override { }

93 void didReceiveData() override { }	93 void didReceiveData() override { }

94 void didFinishLoading() override;	94 void didFinishLoading() override;

95 void didFail(FileError::ErrorCode) override;	95 void didFail(FileError::ErrorCode) override;

96	96

97 FileReaderLoader m_loader;	97 FileReaderLoader m_loader;

98 RawPtrWillBeMember<ImageBitmapFactories> m_factory;	98 RawPtrWillBeMember<ImageBitmapFactories> m_factory;

99 RefPtrWillBeMember<ScriptPromiseResolver> m_resolver;	99 Member<ScriptPromiseResolver> m_resolver;

100 IntRect m_cropRect;	100 IntRect m_cropRect;

101 };	101 };

102	102

103 static ImageBitmapFactories& from(EventTarget&);	103 static ImageBitmapFactories& from(EventTarget&);

104	104

105 template<class GlobalObject>	105 template<class GlobalObject>

106 static ImageBitmapFactories& fromInternal(GlobalObject&);	106 static ImageBitmapFactories& fromInternal(GlobalObject&);

107	107

108 void addLoader(ImageBitmapLoader*);	108 void addLoader(ImageBitmapLoader*);

109 void didFinishLoading(ImageBitmapLoader*);	109 void didFinishLoading(ImageBitmapLoader*);

110	110

111 PersistentHeapHashSetWillBeHeapHashSet<Member<ImageBitmapLoader>> m_pendingL oaders;	111 PersistentHeapHashSetWillBeHeapHashSet<Member<ImageBitmapLoader>> m_pendingL oaders;

112 };	112 };

113	113

114 } // namespace blink	114 } // namespace blink

115	115

116 #endif // ImageBitmapFactories_h	116 #endif // ImageBitmapFactories_h

OLD	NEW