Have ScriptPromiseResolver on the Oilpan heap always.

Source/modules/mediastream/MediaDevices.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/mediastream/MediaDevices.h"
 
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/ScriptState.h"
@@ skipping 16 matching lines @@
         return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(NotSupportedError, "No media device controller available; is this a detached window?"));
 
     MediaDevicesRequest* request = MediaDevicesRequest::create(scriptState, userMedia);
     return request->start();
 }
 
 namespace {
 
 class PromiseSuccessCallback final : public NavigatorUserMediaSuccessCallback {
 public:
-    PromiseSuccessCallback(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
+    PromiseSuccessCallback(ScriptPromiseResolver* resolver)
         : m_resolver(resolver)
     {
     }
 

[haraken, 2015/07/17 01:40:36]

I'm just curious, but is it valid that we reach the destructor without
m_resolver getting resolved? I guess it's not guaranteed that handleEvent is
always called.

[sof, 2015/07/17 09:43:26]

But then handleEvent() would be called for the paired PromiseErrorCallback
instead?

     ~PromiseSuccessCallback()
     {
     }
 
     void handleEvent(MediaStream* stream)
     {
         m_resolver->resolve(stream);
     }
 
     DEFINE_INLINE_VIRTUAL_TRACE()
     {
         visitor->trace(m_resolver);
         NavigatorUserMediaSuccessCallback::trace(visitor);
     }
 
 private:
-    RefPtrWillBeMember<ScriptPromiseResolver> m_resolver;
+    Member<ScriptPromiseResolver> m_resolver;
 };
 
 class PromiseErrorCallback final : public NavigatorUserMediaErrorCallback {
 public:
-    PromiseErrorCallback(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
+    PromiseErrorCallback(ScriptPromiseResolver* resolver)
         : m_resolver(resolver)
     {
     }
 
     ~PromiseErrorCallback()
     {
     }
 
     void handleEvent(NavigatorUserMediaError* error)
     {
         m_resolver->reject(error);
     }
 
     DEFINE_INLINE_VIRTUAL_TRACE()
     {
         visitor->trace(m_resolver);
         NavigatorUserMediaErrorCallback::trace(visitor);
     }
 
 private:
-    RefPtrWillBeMember<ScriptPromiseResolver> m_resolver;
+    Member<ScriptPromiseResolver> m_resolver;
 };
 
 } // namespace
 
 ScriptPromise MediaDevices::getUserMedia(ScriptState* scriptState, const Dictionary& options, ExceptionState& exceptionState)
 {
-    RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+    ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
 
     NavigatorUserMediaSuccessCallback* successCallback = new PromiseSuccessCallback(resolver);
     NavigatorUserMediaErrorCallback* errorCallback = new PromiseErrorCallback(resolver);
 
     Document* document = toDocument(scriptState->executionContext());
     UserMediaController* userMedia = UserMediaController::from(document->frame());
     if (!userMedia)
         return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(NotSupportedError, "No media device controller available; is this a detached window?"));
 
     UserMediaRequest* request = UserMediaRequest::create(document, userMedia, options, successCallback, errorCallback, exceptionState);
     if (!request) {
         ASSERT(exceptionState.hadException());
         return exceptionState.reject(scriptState);
     }
 
     request->start();
     return resolver->promise();
 }
 
 } // namespace blink