Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 123313002: [rAC, OSX] Always close error bubble on focus loss (Closed)

Created:
6 years, 11 months ago by groby-ooo-7-16
Modified:
6 years, 11 months ago
Reviewers:
Ilya Sherman, Dan Beam
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[rAC, OSX] Always close error bubble on focus loss BUG=331124 R=isherman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243338

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/autofill/autofill_details_container.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
groby-ooo-7-16
6 years, 11 months ago (2014-01-02 18:50:42 UTC) #1
Dan Beam
fwiw lgtm (I tried locally and fixes the issue for me)
6 years, 11 months ago (2014-01-06 22:25:35 UTC) #2
Ilya Sherman
LGTM, thanks.
6 years, 11 months ago (2014-01-06 23:07:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/123313002/1
6 years, 11 months ago (2014-01-06 23:08:02 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242169
6 years, 11 months ago (2014-01-07 10:08:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/123313002/1
6 years, 11 months ago (2014-01-07 17:22:29 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 18:32:32 UTC) #7
Message was sent while issue was closed.
Change committed as 243338

Powered by Google App Engine
This is Rietveld 408576698