src/hydrogen.cc - Issue 1233073005: Debugger: prepare code for debugging on a per-function basis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 1233073005: Debugger: prepare code for debugging on a per-function basis. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: addressed comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 7c5d7df04366d65053a554cbd0f554c4729685d7..9b43a1f6e87dd9d4a9107cefd2b18d5c71e67281 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -8154,6 +8154,10 @@ bool HOptimizedGraphBuilder::TryInline(Handle<JSFunction> target,

CompilationInfo target_info(&parse_info);

Handle<SharedFunctionInfo> target_shared(target->shared());

+ if (target_shared->HasDebugInfo()) {

+ TraceInline(target, caller, "target is being debugged");

+ return false;

+ }

if (!Compiler::ParseAndAnalyze(target_info.parse_info())) {

if (target_info.isolate()->has_pending_exception()) {

// Parse or scope error, never optimize this function.

« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/ia32/assembler-ia32-inl.h » ('j') | no next file with comments »