Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Unified Diff: src/heap/objects-visiting-inl.h

Issue 1233073005: Debugger: prepare code for debugging on a per-function basis. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/debug.cc ('K') | « src/heap/mark-compact.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/objects-visiting-inl.h
diff --git a/src/heap/objects-visiting-inl.h b/src/heap/objects-visiting-inl.h
index e3e8e710203ea03bdb376d97a03d6ba6722326bb..6bec9e53a3e7a915a284a1d4c6dcbe3f247504b0 100644
--- a/src/heap/objects-visiting-inl.h
+++ b/src/heap/objects-visiting-inl.h
@@ -659,6 +659,11 @@ bool StaticMarkingVisitor<StaticVisitor>::IsFlushable(
return false;
}
+ // Function is subject to debugging, do not flush.
+ if (shared_info->HasDebugInfo()) {
Michael Starzinger 2015/07/20 11:33:41 Ouch, this is scary! Is this a hard requirement? I
Yang 2015/07/20 12:13:47 Done.
+ return false;
+ }
+
// The function must be compiled and have the source code available,
// to be able to recompile it in case we need the function again.
if (!(shared_info->is_compiled() && HasSourceCode(heap, shared_info))) {
« src/debug.cc ('K') | « src/heap/mark-compact.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698