Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1233073003: Remove duplicate flattening. Defining accessors doesn't call out, so don't assert that the context … (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove duplicate flattening. Defining accessors doesn't call out, so don't assert that the context doesn't change. BUG=v8:4137 LOG=n Committed: https://crrev.com/5a52b9fe9f803931e4362b1cc18be112649e6732 Cr-Commit-Position: refs/heads/master@{#29650}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -21 lines) Patch
M src/objects.cc View 5 chunks +9 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-14 10:31:20 UTC) #2
Igor Sheludko
lgtm
5 years, 5 months ago (2015-07-14 10:45:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233073003/1
5 years, 5 months ago (2015-07-14 14:14:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 14:57:30 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 14:57:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a52b9fe9f803931e4362b1cc18be112649e6732
Cr-Commit-Position: refs/heads/master@{#29650}

Powered by Google App Engine
This is Rietveld 408576698