net/http/http_network_transaction.cc - Issue 1233043003: Remove some legacy versions of StartsWith and EndsWith.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_transaction.cc

Issue 1233043003: Remove some legacy versions of StartsWith and EndsWith. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_network_transaction.cc

diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc

index 76e352eed923aaabcb6d8011f253cd02629acf2a..7fe07c6c16bc6801f9fd5118528188fff480bef2 100644

--- a/net/http/http_network_transaction.cc

+++ b/net/http/http_network_transaction.cc

@@ -1444,7 +1444,8 @@ void HttpNetworkTransaction::RecordSSLFallbackMetrics(int result) {

return;

const std::string& host = request_->url.host();

- bool is_google = base::EndsWith(host, "google.com", true) &&

+ bool is_google = base::EndsWith(host, "google.com",

+ base::CompareCase::SENSITIVE) &&

(host.size() == 10 || host[host.size() - 11] == '.');

if (is_google) {

// Some fraction of successful connections use the fallback, but only due to

« no previous file with comments | « net/base/net_util.cc ('k') | net/http/http_server_properties_impl.cc » ('j') | no next file with comments »