Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: extensions/utility/unpacker_unittest.cc

Issue 1233043003: Remove some legacy versions of StartsWith and EndsWith. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/user_script.cc ('k') | google_apis/drive/test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/utility/unpacker_unittest.cc
diff --git a/extensions/utility/unpacker_unittest.cc b/extensions/utility/unpacker_unittest.cc
index bb99aaeed246a6d4a279e24bf213019abdb67626..82e5a1f7dc1e5bcf4decd4591649df51a1d4790b 100644
--- a/extensions/utility/unpacker_unittest.cc
+++ b/extensions/utility/unpacker_unittest.cc
@@ -171,7 +171,8 @@ TEST_F(UnpackerTest, BadPathError) {
EXPECT_FALSE(unpacker_->Run());
EXPECT_TRUE(base::StartsWith(unpacker_->error_message(),
- ASCIIToUTF16(kExpected), false))
+ ASCIIToUTF16(kExpected),
+ base::CompareCase::INSENSITIVE_ASCII))
<< "Expected prefix: \"" << kExpected << "\", actual error: \""
<< unpacker_->error_message() << "\"";
}
@@ -181,7 +182,8 @@ TEST_F(UnpackerTest, ImageDecodingError) {
SetupUnpacker("bad_image.crx");
EXPECT_FALSE(unpacker_->Run());
EXPECT_TRUE(base::StartsWith(unpacker_->error_message(),
- ASCIIToUTF16(kExpected), false))
+ ASCIIToUTF16(kExpected),
+ base::CompareCase::INSENSITIVE_ASCII))
<< "Expected prefix: \"" << kExpected << "\", actual error: \""
<< unpacker_->error_message() << "\"";
}
« no previous file with comments | « extensions/common/user_script.cc ('k') | google_apis/drive/test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698