components/password_manager/core/browser/password_manager.cc - Issue 1233043003: Remove some legacy versions of StartsWith and EndsWith.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 1233043003: Remove some legacy versions of StartsWith and EndsWith. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/pairing/bluetooth_controller_pairing_controller.cc ('k') | components/plugins/renderer/mobile_youtube_plugin.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager.cc

diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc

index 078b627a1b501c68bb017fef36e65c074b54df89..49d8af61029a148beffc92ad5568d0c067b0b046 100644

--- a/components/password_manager/core/browser/password_manager.cc

+++ b/components/password_manager/core/browser/password_manager.cc

@@ -477,7 +477,8 @@ void PasswordManager::CreatePendingLoginManagers(

iter != forms.end(); ++iter) {

// Don't involve the password manager if this form corresponds to

// SpdyProxy authentication, as indicated by the realm.

- if (base::EndsWith(iter->signon_realm, kSpdyProxyRealm, true))

+ if (base::EndsWith(iter->signon_realm, kSpdyProxyRealm,

+ base::CompareCase::SENSITIVE))

continue;

bool old_manager_found = false;

for (const auto& old_manager : old_login_managers) {