Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: components/google/core/browser/google_util.cc

Issue 1233043003: Remove some legacy versions of StartsWith and EndsWith. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/google/core/browser/google_util.cc
diff --git a/components/google/core/browser/google_util.cc b/components/google/core/browser/google_util.cc
index 53265023ffd2233b506aa10a60752f07871bc53c..1eada344379f84a53b771eb2efe6c097a6f63d84 100644
--- a/components/google/core/browser/google_util.cc
+++ b/components/google/core/browser/google_util.cc
@@ -57,7 +57,8 @@ bool IsValidHostName(const std::string& host,
if (base::LowerCaseEqualsASCII(host_minus_tld, domain_in_lower_case.c_str()))
return true;
if (subdomain_permission == google_util::ALLOW_SUBDOMAIN)
- return base::EndsWith(host_minus_tld, "." + domain_in_lower_case, false);
+ return base::EndsWith(host_minus_tld, "." + domain_in_lower_case,
+ base::CompareCase::INSENSITIVE_ASCII);
return base::LowerCaseEqualsASCII(host_minus_tld,
("www." + domain_in_lower_case).c_str());
}
« no previous file with comments | « components/devtools_http_handler/devtools_http_handler.cc ('k') | components/omnibox/browser/keyword_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698