chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm - Issue 1233043003: Remove some legacy versions of StartsWith and EndsWith.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

Issue 1233043003: Remove some legacy versions of StartsWith and EndsWith. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc ('k') | chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

index 840de4691a5448a42c11920eca203af5776de4a5..0fa91ec3e4fef6577e4c4391d7b71c22d55b2c15 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

@@ -563,8 +563,10 @@ NSAttributedString* CreateClassifiedAttributedString(

match.GetAdditionalInfo(kACMatchPropertyContentsStartIndex),

&contentsStartIndex);

// Ignore invalid state.

- if (!base::StartsWith(match.fill_into_edit, inputText, true) ||

- !base::EndsWith(match.fill_into_edit, match.contents, true) ||

+ if (!base::StartsWith(match.fill_into_edit, inputText,

+ base::CompareCase::SENSITIVE) ||

+ !base::EndsWith(match.fill_into_edit, match.contents,

+ base::CompareCase::SENSITIVE) ||

((size_t)contentsStartIndex >= inputText.length())) {

return 0;

}