chrome/browser/sync/test/integration/bookmarks_helper.cc - Issue 1233043003: Remove some legacy versions of StartsWith and EndsWith.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/bookmarks_helper.cc

Issue 1233043003: Remove some legacy versions of StartsWith and EndsWith. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/supervised_user_url_filter.cc ('k') | chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/bookmarks_helper.cc

diff --git a/chrome/browser/sync/test/integration/bookmarks_helper.cc b/chrome/browser/sync/test/integration/bookmarks_helper.cc

index ebae3b2538825590dfdcb4397c554e1d9e5b92f2..08a863e0a5673c148fb2a276d357624c6380e161 100644

--- a/chrome/browser/sync/test/integration/bookmarks_helper.cc

+++ b/chrome/browser/sync/test/integration/bookmarks_helper.cc

@@ -964,7 +964,8 @@ gfx::Image CreateFavicon(SkColor color) {

gfx::Image Create1xFaviconFromPNGFile(const std::string& path) {

const char* kPNGExtension = ".png";

- if (!base::EndsWith(path, kPNGExtension, false))

+ if (!base::EndsWith(path, kPNGExtension,

+ base::CompareCase::INSENSITIVE_ASCII))

return gfx::Image();

base::FilePath full_path;