Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3753)

Unified Diff: chrome/browser/component_updater/cld_component_installer_unittest.cc

Issue 1233043003: Remove some legacy versions of StartsWith and EndsWith. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/cld_component_installer_unittest.cc
diff --git a/chrome/browser/component_updater/cld_component_installer_unittest.cc b/chrome/browser/component_updater/cld_component_installer_unittest.cc
index ab40b3532d7c95c33d7f32df4209a6419f2c770c..aa19c256d33f23c3ceb0daea83af1270eb68ff90 100644
--- a/chrome/browser/component_updater/cld_component_installer_unittest.cc
+++ b/chrome/browser/component_updater/cld_component_installer_unittest.cc
@@ -102,7 +102,8 @@ TEST_F(CldComponentInstallerTest, GetInstalledPath) {
const base::FilePath base_dir;
const base::FilePath result =
CldComponentInstallerTraits::GetInstalledPath(base_dir);
- ASSERT_TRUE(base::EndsWith(result.value(), kTestCldDataFileName, true));
+ ASSERT_TRUE(base::EndsWith(result.value(), kTestCldDataFileName,
+ base::CompareCase::SENSITIVE));
}
TEST_F(CldComponentInstallerTest, GetBaseDirectory) {
@@ -127,8 +128,10 @@ TEST_F(CldComponentInstallerTest, ComponentReady) {
traits_.ComponentReady(version, install_dir, manifest.Pass());
base::FilePath result = CldComponentInstallerTraits::GetLatestCldDataFile();
ASSERT_TRUE(base::StartsWith(result.AsUTF16Unsafe(),
- install_dir.AsUTF16Unsafe(), true));
- ASSERT_TRUE(base::EndsWith(result.value(), kTestCldDataFileName, true));
+ install_dir.AsUTF16Unsafe(),
+ base::CompareCase::SENSITIVE));
+ ASSERT_TRUE(base::EndsWith(result.value(), kTestCldDataFileName,
+ base::CompareCase::SENSITIVE));
}
} // namespace component_updater

Powered by Google App Engine
This is Rietveld 408576698