Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: chrome/common/extensions/api/networking_private/networking_private_crypto.cc

Issue 1233043003: Remove some legacy versions of StartsWith and EndsWith. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/api/networking_private/networking_private_cry pto.h" 5 #include "chrome/common/extensions/api/networking_private/networking_private_cry pto.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "extensions/common/cast/cast_cert_validator.h" 10 #include "extensions/common/cast/cast_cert_validator.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 if (verification_result.Failure()) { 58 if (verification_result.Failure()) {
59 LOG(ERROR) << kErrorPrefix << verification_result.GetLogString(); 59 LOG(ERROR) << kErrorPrefix << verification_result.GetLogString();
60 return false; 60 return false;
61 } 61 }
62 62
63 // Check that the device listed in the certificate is correct. 63 // Check that the device listed in the certificate is correct.
64 // Something like evt_e161 001a11ffacdf 64 // Something like evt_e161 001a11ffacdf
65 std::string common_name = verification_context->GetCommonName(); 65 std::string common_name = verification_context->GetCommonName();
66 std::string translated_mac; 66 std::string translated_mac;
67 base::RemoveChars(connected_mac, ":", &translated_mac); 67 base::RemoveChars(connected_mac, ":", &translated_mac);
68 if (!base::EndsWith(common_name, translated_mac, false)) { 68 if (!base::EndsWith(common_name, translated_mac,
69 base::CompareCase::INSENSITIVE_ASCII)) {
69 LOG(ERROR) << kErrorPrefix << "MAC addresses don't match."; 70 LOG(ERROR) << kErrorPrefix << "MAC addresses don't match.";
70 return false; 71 return false;
71 } 72 }
72 73
73 // Use the public key from verified certificate to verify |signature| over 74 // Use the public key from verified certificate to verify |signature| over
74 // |data|. 75 // |data|.
75 verification_result = 76 verification_result =
76 verification_context->VerifySignatureOverData(signature, data); 77 verification_context->VerifySignatureOverData(signature, data);
77 78
78 if (verification_result.Failure()) { 79 if (verification_result.Failure()) {
79 LOG(ERROR) << kErrorPrefix << verification_result.GetLogString(); 80 LOG(ERROR) << kErrorPrefix << verification_result.GetLogString();
80 return false; 81 return false;
81 } 82 }
82 return true; 83 return true;
83 } 84 }
84 85
85 } // namespace networking_private_crypto 86 } // namespace networking_private_crypto
OLDNEW
« no previous file with comments | « chrome/browser/web_applications/web_app_mac.mm ('k') | chrome/common/extensions/chrome_extensions_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698