Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 123303004: Fix bug in X event processing. (Closed)

Created:
6 years, 11 months ago by jcgregorio
Modified:
6 years, 11 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

An SkOSWindow for Unix may experience stuttering, with missed events or long delays before events are processed when using SkEvent.postDelay(). The issue is with the use of a select loop to watch for events coming into the x11 file descriptor for the display. It turns out there may be XEvents queued in memory but not yet processed that need to be handled before entering the select loop. See: http://developerweb.net/viewtopic.php?id=3184 BUG=1960 Committed: http://code.google.com/p/skia/source/detail?r=12874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/views/unix/SkOSWindow_Unix.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jcgregorio
6 years, 11 months ago (2014-01-02 21:35:58 UTC) #1
reed1
the bots don't exercise this stuff. lgtm assuming you've build and run (and interacted with) ...
6 years, 11 months ago (2014-01-02 21:52:38 UTC) #2
jcgregorio
On 2014/01/02 21:52:38, reed1 wrote: > the bots don't exercise this stuff. lgtm assuming you've ...
6 years, 11 months ago (2014-01-02 22:01:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/123303004/1
6 years, 11 months ago (2014-01-02 22:01:12 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-02 22:21:49 UTC) #5
Message was sent while issue was closed.
Change committed as 12874

Powered by Google App Engine
This is Rietveld 408576698