Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 12330184: Use different client interface for WebLayerTreeViewForTesting to decouple from WebLayerTreeViewClie… (Closed)

Created:
7 years, 9 months ago by jamesr
Modified:
7 years, 9 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Use different client interface for WebLayerTreeViewForTesting to decouple from WebLayerTreeViewClient WebLayerTreeView when used in production (i.e. be content) has different requirements from DumpRenderTree. In DRT, we need to route two calls from the compositor into DRT - Layout() and ScheduleComposite(). Neither are needed in the non-DRT embedding of WebLayerTreeView. This introduces a new client interface for DRT to use that only has these two functions. I've left the old path in place to keep things from breaking until the WebKit change rolls in, after that point I'll remove the WebLayerTreeViewClient references from WebLayerTreeViewImplForTesting completely. R=enne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185341

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -5 lines) Patch
M webkit/compositor_bindings/web_layer_tree_view_impl_for_testing.h View 3 chunks +5 lines, -0 lines 0 comments Download
M webkit/compositor_bindings/web_layer_tree_view_impl_for_testing.cc View 3 chunks +13 lines, -3 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/support/webkit_support.h View 1 chunk +12 lines, -0 lines 0 comments Download
M webkit/support/webkit_support.cc View 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
This stuff is crazy. WebKit side is https://bugs.webkit.org/show_bug.cgi?id=111017, has to land after this.
7 years, 9 months ago (2013-02-27 22:59:50 UTC) #1
jamesr
7 years, 9 months ago (2013-02-27 23:49:33 UTC) #2
enne (OOO)
lgtm
7 years, 9 months ago (2013-02-28 18:17:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/12330184/1
7 years, 9 months ago (2013-02-28 19:01:37 UTC) #4
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=15129
7 years, 9 months ago (2013-02-28 21:59:04 UTC) #5
jamesr
7 years, 9 months ago (2013-02-28 22:09:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r185341 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698