Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Side by Side Diff: tools/dom/src/dart2js_Conversions.dart

Issue 12330174: Revert "Revert "Converting dart:html to use DateTime rather than Date."" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/dom/scripts/systemhtml.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 5
6 // Conversions for Window. These check if the window is the local 6 // Conversions for Window. These check if the window is the local
7 // window, and if it's not, wraps or unwraps it with a secure wrapper. 7 // window, and if it's not, wraps or unwraps it with a secure wrapper.
8 // We need to test for EventTarget here as well as it's a base type. 8 // We need to test for EventTarget here as well as it's a base type.
9 // We omit an unwrapper for Window as no methods take a non-local 9 // We omit an unwrapper for Window as no methods take a non-local
10 // window as a parameter. 10 // window as a parameter.
11 11
12 part of html; 12 part of html;
13 13
14 DateTime _convertNativeToDart_DateTime(date) {
15 var millisSinceEpoch = JS('int', '#.getTime()', date);
16 return new DateTime.fromMillisecondsSinceEpoch(millisSinceEpoch, isUtc: true);
17 }
18
19 _convertDartToNative_DateTime(DateTime date) {
20 return JS('', 'new Date(#)', date.millisecondsSinceEpoch);
21 }
22
14 WindowBase _convertNativeToDart_Window(win) { 23 WindowBase _convertNativeToDart_Window(win) {
15 return _DOMWindowCrossFrame._createSafe(win); 24 return _DOMWindowCrossFrame._createSafe(win);
16 } 25 }
17 26
18 EventTarget _convertNativeToDart_EventTarget(e) { 27 EventTarget _convertNativeToDart_EventTarget(e) {
19 // Assume it's a Window if it contains the setInterval property. It may be 28 // Assume it's a Window if it contains the setInterval property. It may be
20 // from a different frame - without a patched prototype - so we cannot 29 // from a different frame - without a patched prototype - so we cannot
21 // rely on Dart type checking. 30 // rely on Dart type checking.
22 if (JS('bool', r'"setInterval" in #', e)) 31 if (JS('bool', r'"setInterval" in #', e))
23 return _DOMWindowCrossFrame._createSafe(e); 32 return _DOMWindowCrossFrame._createSafe(e);
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 77
69 // We can get rid of this conversion if _TypedImageData implements the fields 78 // We can get rid of this conversion if _TypedImageData implements the fields
70 // with native names. 79 // with native names.
71 _convertDartToNative_ImageData(ImageData imageData) { 80 _convertDartToNative_ImageData(ImageData imageData) {
72 if (imageData is _TypedImageData) { 81 if (imageData is _TypedImageData) {
73 return JS('', '{data: #, height: #, width: #}', 82 return JS('', '{data: #, height: #, width: #}',
74 imageData.data, imageData.height, imageData.width); 83 imageData.data, imageData.height, imageData.width);
75 } 84 }
76 return imageData; 85 return imageData;
77 } 86 }
OLDNEW
« no previous file with comments | « tools/dom/scripts/systemhtml.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698