Issue 12330169: Add separate LocalFileChangeTracer tests for Copy/Move

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12330169: Add separate LocalFileChangeTracer tests for Copy/Move (Closed)

Created:
7 years, 9 months ago by kinuko

Modified:
7 years, 9 months ago

Reviewers:
nhiroki

CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org, tzik

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add separate LocalFileChangeTracer tests for Copy/Move So that we can more explicitly test what changes we track for Copy/Move operations. BUG=none TEST=LocalFileChangeTrackerTest.Restore* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185163

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -58 lines)			Patch
	M	webkit/fileapi/syncable/local_file_change_tracker_unittest.cc	View		9 chunks	+119 lines, -58 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kinuko

Can you review? I need these specific tests to verify my other refactoring. Thanks!

7 years, 9 months ago (2013-02-27 12:59:01 UTC) #1

kinuko

7 years, 9 months ago (2013-02-28 05:21:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r185163 (presubmit successful).

Expand Messages | Collapse Messages