Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 12330154: Merge 182244 (Closed)

Created:
7 years, 10 months ago by Mark P
Modified:
7 years, 10 months ago
Reviewers:
Mark P
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 182244 > Omnibox: Possibly Fix Rare OpenMatch Crash > > The associated bug seems to imply a crash on this line > ClassifyPage(controller_->GetWebContents()->GetURL()) > in OmniboxEditModel::OpenMatch(). > > This change corrects the part of the test that may fail > (if there's no active tab for some reason). > I think controller_ is always valid (the rest of the edit > model code use it without testing it for non-NULL). > But I see at least two places in OmniboxEditModel that > test for the non-NULLness of controller_->GetWebContents(). > Hence, I think it might be able to be NULL, so this > change adds a test for it here too. > > TEST=new code compiles > BUG=142931 > > > Review URL: https://chromiumcodereview.appspot.com/12250014 TBR=mpearson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184741

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark P
7 years, 10 months ago (2013-02-26 21:48:39 UTC) #1
Mark P
7 years, 10 months ago (2013-02-26 21:48:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r184741.

Powered by Google App Engine
This is Rietveld 408576698