Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: runtime/lib/integers_patch.dart

Issue 12330149: Dart VM compiler cannot optimize methods with try/catch yet, factor the code out -> 30% gain on a J… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/integers_patch.dart
===================================================================
--- runtime/lib/integers_patch.dart (revision 19062)
+++ runtime/lib/integers_patch.dart (working copy)
@@ -15,9 +15,14 @@
/* patch */ static int parse(String source,
{ int radix,
int onError(String str) }) {
+ if ((radix == null) && (onError == null)) return _parse(source);
+ return _slowParse(source, radix, onError);
+ }
+
+ static int _slowParse(String source, int radix, int onError(String str)) {
if (source is! String) throw new ArgumentError(source);
if (radix == null) {
- if (onError == null) return _parse(source);
+ assert(onError != null);
try {
return _parse(source);
} on FormatException {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698