Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2357)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/chromeos/login/login_utils.cc

Issue 12330137: Allow normal users to change per session flags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments from Offline discussion with Nico. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_resources.grd ('k') | chrome/browser/prefs/browser_prefs.cc » ('j') | chrome/browser/ui/webui/flags_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/login_utils.cc
diff --git a/chrome/browser/chromeos/login/login_utils.cc b/chrome/browser/chromeos/login/login_utils.cc
index edace2aa0c050dc858e7bc222368cafb344b9fef..7842e150784f58554bed9c7661b688ebcfb37805 100644
--- a/chrome/browser/chromeos/login/login_utils.cc
+++ b/chrome/browser/chromeos/login/login_utils.cc
@@ -26,6 +26,7 @@
#include "base/threading/worker_pool.h"
#include "base/time.h"
#include "base/utf_string_conversions.h"
+#include "chrome/browser/about_flags.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/browser_shutdown.h"
#include "chrome/browser/chromeos/boot_times_loader.h"
@@ -283,6 +284,10 @@ void LoginUtilsImpl::DoBrowserLaunch(Profile* profile,
int return_code;
chrome::startup::IsFirstRun first_run = first_run::IsChromeFirstRun() ?
chrome::startup::IS_FIRST_RUN : chrome::startup::IS_NOT_FIRST_RUN;
+
+ // TODO(pastarmovj): Restart the browser and apply any flags have been set
Mattias Nissler (ping if slow) 2013/03/02 22:43:49 grammar
pastarmovj 2013/03/04 14:31:52 Done.
+ // by the user. See: http://crosbug.com/39249
+
browser_creator.LaunchBrowser(*CommandLine::ForCurrentProcess(),
profile,
base::FilePath(),
« no previous file with comments | « chrome/browser/browser_resources.grd ('k') | chrome/browser/prefs/browser_prefs.cc » ('j') | chrome/browser/ui/webui/flags_ui.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698