sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart - Issue 12330135: Make instance methods whose names collide with intercepted methods have the interceptor calling con…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

Issue 12330135: Make instance methods whose names collide with intercepted methods have the interceptor calling con… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/lib/interceptors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart (revision 19306)

+++ sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart (working copy)

@@ -484,7 +484,9 @@

emitIsChecks();

jsAst.Expression makeCallOnThis(String functionName) {

- return js.fun([], js.return_(js['$functionName(this)']));

+ // Because we know the function is intercepted, we need an extra

+ // parameter.

+ return js.fun(['_'], js.return_(js['$functionName(this)']));

}

// In order to have the toString method on every native class,

@@ -501,7 +503,9 @@

// Same as above, but for operator==.

String equalsName = backend.namer.publicInstanceMethodNameByArity(

const SourceString('=='), 1);

- addProperty(equalsName, js.fun(['a'],

+ // Because we know the function is intercepted, we need an extra

+ // parameter.

+ addProperty(equalsName, js.fun(['_', 'a'],

js.return_(js['this === a'])));

// If the native emitter has been asked to take care of the