mac: Fix sending of mouse moved events after resizing window's lower left corner

ui/base/cocoa/base_view.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/cocoa/base_view.h"
 
 NSString* kViewDidBecomeFirstResponder =
     @"Chromium.kViewDidBecomeFirstResponder";
 NSString* kSelectionDirection = @"Chromium.kSelectionDirection";
 
+const int kTrackingOptions = NSTrackingMouseMoved |
+                             NSTrackingMouseEnteredAndExited |
+                             NSTrackingActiveAlways;
+
 @implementation BaseView
 
 - (id)initWithFrame:(NSRect)frame {
   self = [super initWithFrame:frame];
   if (self) {
-    trackingArea_ =
-        [[NSTrackingArea alloc] initWithRect:frame
-                                     options:NSTrackingMouseMoved |
-                                             NSTrackingMouseEnteredAndExited |
-                                             NSTrackingActiveInActiveApp |
-                                             NSTrackingInVisibleRect
-                                       owner:self
-                                    userInfo:nil];
+    trackingArea_ = [[NSTrackingArea alloc] initWithRect:frame

[Alexei Svitkine (slow), 2013/03/14 00:42:47]

Could this just call [self refreshTrackingAreaSize], or does [self
removeTrackingArea:nil] cause problems?

+                                                 options:kTrackingOptions
+                                                   owner:self
+                                                userInfo:nil];
     [self addTrackingArea:trackingArea_];
   }
   return self;
 }
 
 - (void)dealloc {
   [self removeTrackingArea:trackingArea_];
   [trackingArea_ release];
 
   [super dealloc];
@@ skipping 102 matching lines @@
   new_rect.set_y(NSHeight([self bounds]) - new_rect.bottom());
   return new_rect;
 }
 
 - (NSRect)flipRectToNSRect:(gfx::Rect)rect {
   NSRect new_rect(NSRectFromCGRect(rect.ToCGRect()));
   new_rect.origin.y = NSHeight([self bounds]) - NSMaxY(new_rect);
   return new_rect;
 }
 
+- (void)refreshTrackingAreaSize {

[Alexei Svitkine (slow), 2013/03/14 00:42:47]

Should this be called refreshTrackingAreaRect, since it's not just the size
you're interested in, right?

+  // NSTrackingInVisibleRect doesn't work correctly with Lion's window resizing,
+  // http://crbug.com/176725 /  http://openradar.appspot.com/radar?id=2773401 .
+  // Tear down old tracking area and create a new one as workaround.
+  [self removeTrackingArea:trackingArea_];
+  [trackingArea_ release];
+  trackingArea_ = [[NSTrackingArea alloc] initWithRect:[self frame]
+                                               options:kTrackingOptions
+                                                 owner:self
+                                              userInfo:nil];
+  [self addTrackingArea:trackingArea_];
+}
+
+- (void)setFrame:(NSRect)newRect {
+  BOOL sizeChanged = !NSEqualSizes([self frame].size, newRect.size);
+  [super setFrame:newRect];
+
+  // NB: -[NSView setFrame:] calls through -setFrameSize:.
+  if (!sizeChanged)
+    [self refreshTrackingAreaSize];

[Alexei Svitkine (slow), 2013/03/14 00:42:47]

So this is called because -[NSView setFrame:] doesn't call -setFrameSize: if the
size hasn't changed? Maybe clarify this in the comment ("if the size changed").

It would also be nice to at-least have a test for what you say in the comment
(that setFrame: does call setFrameSize:), to make sure we don't break if the
implementation of -setFrame: changes.

+}
+
+- (void)setFrameSize:(NSSize)newSize {
+  [super setFrameSize:newSize];
+  [self refreshTrackingAreaSize];
+}
+
 @end