tools/json_schema_compiler/model.py - Issue 12330089: JSON compiler to include "customBindings" in the function name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/model.py

Issue 12330089: JSON compiler to include "customBindings" in the function name. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/model.py

===================================================================

--- tools/json_schema_compiler/model.py (revision 182503)

+++ tools/json_schema_compiler/model.py (working copy)

@@ -117,6 +117,7 @@

self.origin = origin

self.parent = parent

self.instance_of = json.get('isInstanceOf', None)

+ self.custom_bindings = json.get('customBindings', None)

not at google - send to devlin 2013/02/23 00:13:07 what is this change for?

SanjoyPal 2013/02/23 00:19:35 Otherwise i am not able to access type_.custom_bin

not at google - send to devlin 2013/02/23 00:22:55 I had no idea we had that. We shouldn't. The fix

# TODO(kalman): Only objects need functions/events/properties, but callers

# assume that all types have them. Fix this.

« no previous file with comments | « tools/json_schema_compiler/cpp_bundle_generator.py ('k') | no next file » | no next file with comments »