Issue 12330081: Merge 143032

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12330081: Merge 143032 (Closed)

Created:
7 years, 10 months ago by aelias_OOO_until_Jul13

Modified:
7 years, 10 months ago

Reviewers:
aelias_OOO_until_Jul13

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/

Visibility:
Public.

More Reviews

Description

Merge 143032 > [chromium] WebInputEventBuilders should not reverse page scale > https://bugs.webkit.org/show_bug.cgi?id=109901 > > Reviewed by James Robinson. > > Though in theory logical that if WebInputEvent -> PlatformEvent > conversions divide by page scale, then the reverse builders should > multiply, in reality the only user of the reverse builders is > plugins which expect the same coordinate space as WebCore. > > * src/WebInputEventConversion.cpp: > (WebKit::updateWebMouseEventFromWebCoreMouseEvent): > (WebKit::WebMouseEventBuilder::WebMouseEventBuilder): > (WebKit::addTouchPoints): > (WebKit::WebGestureEventBuilder::WebGestureEventBuilder): > * tests/WebInputEventConversionTest.cpp: > (WebCore::TEST): > TBR=aelias@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143777

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+129 lines, -33 lines)			Patch
M	Source/WebKit/chromium/ChangeLog	View	1 chunk	+101 lines, -0 lines	0 comments	Download
M	Source/WebKit/chromium/src/WebInputEventConversion.cpp	View	9 chunks	+14 lines, -21 lines	0 comments	Download
M	Source/WebKit/chromium/tests/WebInputEventConversionTest.cpp	View	3 chunks	+14 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

aelias_OOO_until_Jul13

7 years, 10 months ago (2013-02-22 20:33:36 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r143777.

Expand Messages | Collapse Messages