Issue 12330079: Revert 184133

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12330079: Revert 184133 (Closed)

Created:
7 years, 10 months ago by vandebo (ex-Chrome)

Modified:
7 years, 10 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 184133 It failed in this way: [ RUN ] HKDFTest.HKDFConstruct c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\vector(932) : Assertion failed: vector subscript out of range c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\vector(933) : Assertion failed: "Standard C++ Libraries Out of Range" && 0 http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%281%29/builds/33019/steps/crypto_unittests/logs/stdio > Porting of HKDF changes from server. > > Merge internal CL: 40300624 > > > Review URL: https://chromiumcodereview.appspot.com/12326029 TBR=rtenneti@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184146

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -251 lines)			Patch
MM	crypto/crypto.gyp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
D	crypto/hkdf.h	View	1 chunk	+0 lines, -64 lines	0 comments	Download
D	crypto/hkdf.cc	View	1 chunk	+0 lines, -92 lines	0 comments	Download
D	crypto/hkdf_unittest.cc	View	1 chunk	+0 lines, -92 lines	0 comments	Download

Total messages: 3 (0 generated)

Message was sent while issue was closed.

lgtm