Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Unified Diff: chrome/browser/profiles/profile_keyed_base_factory.h

Issue 12330073: Disable ProfileKeyedServices on import process by default. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to ToT Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_keyed_base_factory.h
diff --git a/chrome/browser/profiles/profile_keyed_base_factory.h b/chrome/browser/profiles/profile_keyed_base_factory.h
index 3d9899f1d5641f5779ebe8d6e1a7a1a9270c319b..bfcb054ca0794d536e27f2e7d3bf139ace4d0d86 100644
--- a/chrome/browser/profiles/profile_keyed_base_factory.h
+++ b/chrome/browser/profiles/profile_keyed_base_factory.h
@@ -72,6 +72,14 @@ class ProfileKeyedBaseFactory : public base::NonThreadSafe {
// services they use.)
virtual bool ServiceIsNULLWhileTesting() const;
+ // By default, we do not create any services on the import process. Any
+ // services that are required to perform an import should override this method
+ // and return |false|. Note that any services created on the import process
+ // may run in parallel with another instance of the service running in the
+ // main browser process, so care must be taken to avoid conflicting use of
+ // non-shareable resources like DB files.
+ virtual bool ServiceIsNULLOnImportProcess() const;
+
// Interface for people building a type of ProfileKeyedFactory: -------------
// A helper object actually listens for notifications about Profile

Powered by Google App Engine
This is Rietveld 408576698