chrome/browser/prefs/pref_service_syncable.cc - Issue 12330008: Get rid of the ability to unregister preferences.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/pref_service_syncable.cc

Issue 12330008: Get rid of the ability to unregister preferences. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix browser_tests that tested migration in PrefsTabHelper. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prefs/pref_service_syncable.cc

diff --git a/chrome/browser/prefs/pref_service_syncable.cc b/chrome/browser/prefs/pref_service_syncable.cc

index cf1ab7a54b8b22226d9c90d83da34f2da28e101a..5d26e17e37cd3c428fb6191d5da7816309e2526d 100644

--- a/chrome/browser/prefs/pref_service_syncable.cc

+++ b/chrome/browser/prefs/pref_service_syncable.cc

@@ -132,13 +132,6 @@ void PrefServiceSyncable::AddRegisteredSyncablePreference(const char* path) {

pref_sync_associator_.RegisterPref(path);

}

-void PrefServiceSyncable::RemoveRegisteredPreference(const char* path) {

- PrefService::RemoveRegisteredPreference(path);

- if (pref_sync_associator_.IsPrefRegistered(path))

- pref_sync_associator_.UnregisterPref(path);

void PrefServiceSyncable::OnIsSyncingChanged() {

FOR_EACH_OBSERVER(PrefServiceSyncableObserver, observer_list_,

OnIsSyncingChanged());