Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: chrome/browser/chromeos/login/oauth2_login_manager.cc

Issue 12330008: Get rid of the ability to unregister preferences. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix browser_tests that tested migration in PrefsTabHelper. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/oauth2_login_manager.cc
diff --git a/chrome/browser/chromeos/login/oauth2_login_manager.cc b/chrome/browser/chromeos/login/oauth2_login_manager.cc
index 60ffa3ec03b11e6a5a904429402490a2a8a77de6..4567da3c8cd5a2bb298f97ca1c944852dc1013c6 100644
--- a/chrome/browser/chromeos/login/oauth2_login_manager.cc
+++ b/chrome/browser/chromeos/login/oauth2_login_manager.cc
@@ -20,6 +20,14 @@
#include "google_apis/gaia/gaia_constants.h"
#include "net/url_request/url_request_context_getter.h"
+namespace {
+
+// Prefs registered only for migration purposes.
+const char kOAuth1Token[] = "settings.account.oauth1_token";
+const char kOAuth1Secret[] = "settings.account.oauth1_secret";
+
+} // namespace
+
namespace chromeos {
OAuth2LoginManager::OAuth2LoginManager(OAuthLoginManager::Delegate* delegate)
@@ -30,6 +38,15 @@ OAuth2LoginManager::OAuth2LoginManager(OAuthLoginManager::Delegate* delegate)
OAuth2LoginManager::~OAuth2LoginManager() {
}
+void OAuth2LoginManager::RegisterUserPrefs(PrefRegistrySyncable* registry) {
+ registry->RegisterStringPref(kOAuth1Token,
+ "",
+ PrefRegistrySyncable::UNSYNCABLE_PREF);
+ registry->RegisterStringPref(kOAuth1Secret,
+ "",
+ PrefRegistrySyncable::UNSYNCABLE_PREF);
+}
+
void OAuth2LoginManager::RestoreSession(
Profile* user_profile,
net::URLRequestContextGetter* auth_request_context,
@@ -93,19 +110,8 @@ TokenService* OAuth2LoginManager::SetupTokenService() {
void OAuth2LoginManager::RemoveLegacyTokens() {
PrefService* prefs = user_profile_->GetPrefs();
- // TODO(joi): Handle migration more elegantly.
- scoped_refptr<PrefRegistrySyncable> registry(
- static_cast<PrefRegistrySyncable*>(prefs->DeprecatedGetPrefRegistry()));
- registry->RegisterStringPref(prefs::kOAuth1Token,
- "",
- PrefRegistrySyncable::UNSYNCABLE_PREF);
- registry->RegisterStringPref(prefs::kOAuth1Secret,
- "",
- PrefRegistrySyncable::UNSYNCABLE_PREF);
- prefs->ClearPref(prefs::kOAuth1Token);
- prefs->ClearPref(prefs::kOAuth1Secret);
- registry->DeprecatedUnregisterPreference(prefs::kOAuth1Token);
- registry->DeprecatedUnregisterPreference(prefs::kOAuth1Secret);
+ prefs->ClearPref(kOAuth1Token);
+ prefs->ClearPref(kOAuth1Secret);
}
void OAuth2LoginManager::StoreOAuth2Tokens(

Powered by Google App Engine
This is Rietveld 408576698