Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2832)

Unified Diff: base/prefs/pref_registry.h

Issue 12330008: Get rid of the ability to unregister preferences. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head for commit. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/prefs/pref_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/prefs/pref_registry.h
diff --git a/base/prefs/pref_registry.h b/base/prefs/pref_registry.h
index 800c62d8da75620f9caf8ee99d2bb5d565ab0af1..8f39341ce55b2fe9b43f78160e471c5d2a4b9e18 100644
--- a/base/prefs/pref_registry.h
+++ b/base/prefs/pref_registry.h
@@ -30,7 +30,6 @@ class BASE_PREFS_EXPORT PrefRegistry : public base::RefCounted<PrefRegistry> {
public:
typedef PrefValueMap::const_iterator const_iterator;
typedef base::Callback<void(const char*, base::Value*)> RegistrationCallback;
- typedef base::Callback<void(const char*)> UnregistrationCallback;
PrefRegistry();
@@ -41,19 +40,14 @@ class BASE_PREFS_EXPORT PrefRegistry : public base::RefCounted<PrefRegistry> {
const_iterator begin() const;
const_iterator end() const;
- // Exactly one callback can be set for each of two events:
- // Registration and unregistration. If either is set, the callback
- // will be invoked each time registration and/or unregistration has
- // been performed on this object.
+ // Exactly one callback can be set for registration. The callback
+ // will be invoked each time registration has been performed on this
+ // object.
//
- // Calling either of these methods after a callback has already been
- // set will make the object forget the previous callback and use the
- // new one instead.
+ // Calling this method after a callback has already been set will
+ // make the object forget the previous callback and use the new one
+ // instead.
void SetRegistrationCallback(const RegistrationCallback& callback);
- void SetUnregistrationCallback(const UnregistrationCallback& callback);
-
- // Unregisters a preference. This is going away soon.
- void DeprecatedUnregisterPreference(const char* path);
protected:
friend class base::RefCounted<PrefRegistry>;
@@ -66,7 +60,6 @@ class BASE_PREFS_EXPORT PrefRegistry : public base::RefCounted<PrefRegistry> {
private:
RegistrationCallback registration_callback_;
- UnregistrationCallback unregistration_callback_;
DISALLOW_COPY_AND_ASSIGN(PrefRegistry);
};
« no previous file with comments | « no previous file | base/prefs/pref_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698