ServiceWorker: Record result of purging stale resources

ServiceWorker: Record result of purging stale resources

Before this patch, there is no way to know result of purging stale resources.

BUG=n/a

Committed: https://crrev.com/c71cc2ecf056ccb59249ba156d927f087bcae28b
Cr-Commit-Position: refs/heads/master@{#339782}

[nhiroki, 2015-07-17 04:22:13]

Patchset #1 (id:1) has been deleted

[nhiroki, 2015-07-17 04:39:58]

nhiroki@chromium.org changed reviewers:
+ falken@chromium.org

[nhiroki, 2015-07-17 04:39:58]

PTAL, thanks!

[falken, 2015-07-17 07:31:02]

On 2015/07/17 04:39:58, nhiroki wrote:
> PTAL, thanks!

lgtm

[nhiroki, 2015-07-17 07:32:31]

nhiroki@chromium.org changed reviewers:
+ asvitkine@chromium.org

[nhiroki, 2015-07-17 07:32:57]

+asvitkine@ for histograms.xml, ptal

[Alexei Svitkine (slow), 2015-07-17 15:08:52]

https://codereview.chromium.org/1232923003/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_metrics.cc (right):

https://codereview.chromium.org/1232923003/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_metrics.cc:89: net_error);
I think net errors are negative, so you have to negate it here, e.g. see:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/met...

https://codereview.chromium.org/1232923003/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1232923003/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:38280: +    Records result of purging a
stale resource in ServiceWorkerStorage.
Mention whether this is recorded only on error or on success as well.

[nhiroki, 2015-07-21 02:27:23]

Thank you! Updated.

https://codereview.chromium.org/1232923003/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_metrics.cc (right):

https://codereview.chromium.org/1232923003/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_metrics.cc:89: net_error);
On 2015/07/17 15:08:52, Alexei Svitkine wrote:
> I think net errors are negative, so you have to negate it here, e.g. see:
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/met...

Good catch! Done.

https://codereview.chromium.org/1232923003/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1232923003/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:38280: +    Records result of purging a
stale resource in ServiceWorkerStorage.
On 2015/07/17 15:08:52, Alexei Svitkine wrote:
> Mention whether this is recorded only on error or on success as well.

Done.

[Alexei Svitkine (slow), 2015-07-21 15:43:25]

lgtm

[nhiroki, 2015-07-21 22:53:53]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2015-07-21 22:53:53]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/1232923003/#ps60001
(title: "use std::abs")

[commit-bot: I haz the power, 2015-07-21 22:54:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1232923003/60001

[commit-bot: I haz the power, 2015-07-21 23:41:39]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-07-21 23:43:47]

Patchset 3 (id:??) landed as
https://crrev.com/c71cc2ecf056ccb59249ba156d927f087bcae28b
Cr-Commit-Position: refs/heads/master@{#339782}