Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 1232873002: Fix for partially-specified crop rects. (Closed)

Created:
5 years, 5 months ago by Stephen White
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix for partially-specified crop rects. When only the left or top edge of a crop rect is given, the right and bottom should be computed based on the incoming width and height, not based on the crop rect's width & height. This complies more accurately with SVG semantics. BUG=240827 Committed: https://skia.googlesource.com/skia/+/24d2a7b463d585f9300ceac946431e822531d504

Patch Set 1 #

Patch Set 2 : Fix 100-cols #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -8 lines) Patch
M src/core/SkImageFilter.cpp View 1 2 chunks +24 lines, -8 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Stephen White
Rob: PTAL. Thanks! (Note: this is a copy of https://codereview.chromium.org/1234873005/ without the name changes. Those ...
5 years, 5 months ago (2015-07-13 15:47:28 UTC) #2
robertphillips
lgtm
5 years, 5 months ago (2015-07-13 17:10:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232873002/10003
5 years, 5 months ago (2015-07-13 17:20:00 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 17:27:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:10003) as
https://skia.googlesource.com/skia/+/24d2a7b463d585f9300ceac946431e822531d504

Powered by Google App Engine
This is Rietveld 408576698