Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1232843005: Test that TypedArray properties cannot be set in strict mode (Closed)

Created:
5 years, 5 months ago by Dan Ehrenberg
Modified:
5 years, 5 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Additional TypedArray tests - Test that TypedArray properties cannot be set in strict mode Properties like %TypedArray%.prototype.length have a getter and no setter. This test verifies that property, which was apparently not true in the past or had no test ensuring throwing in this case. - Test that TypedArray integer indexed properties (array elements) are not configurable Both of these have passed for some time, but there are open bugs against them and apparently no tests verifying that they are fixed. BUG=v8:3048, v8:3799 LOG=N R=adamk Committed: https://crrev.com/8068b91d15733eee3f97bb741197a1b6da1550e1 Cr-Commit-Position: refs/heads/master@{#29717}

Patch Set 1 #

Patch Set 2 : Test nonconfigurable integer indexed properties #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M test/mjsunit/es6/typedarray.js View 1 2 chunks +11 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (1 generated)
Dan Ehrenberg
5 years, 5 months ago (2015-07-16 01:14:01 UTC) #1
adamk
On your CL description: to specify multiple bugs, add a comma between them on a ...
5 years, 5 months ago (2015-07-16 22:24:22 UTC) #2
Dan Ehrenberg
https://codereview.chromium.org/1232843005/diff/20001/test/mjsunit/es6/typedarray.js File test/mjsunit/es6/typedarray.js (right): https://codereview.chromium.org/1232843005/diff/20001/test/mjsunit/es6/typedarray.js#newcode421 test/mjsunit/es6/typedarray.js:421: var d = Object.getOwnPropertyDescriptor(constructor.prototype, name); On 2015/07/16 22:24:22, adamk ...
5 years, 5 months ago (2015-07-16 23:54:55 UTC) #3
adamk
lgtm, no need to duplicate the check for named properties (which aren't exotic on these ...
5 years, 5 months ago (2015-07-16 23:55:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232843005/20001
5 years, 5 months ago (2015-07-16 23:55:51 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-17 00:21:16 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 00:21:43 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8068b91d15733eee3f97bb741197a1b6da1550e1
Cr-Commit-Position: refs/heads/master@{#29717}

Powered by Google App Engine
This is Rietveld 408576698